Skip to content

UI: remove Percy snapshot testing#27754

Draft
tgross wants to merge 1 commit intomainfrom
ui-remove-percy
Draft

UI: remove Percy snapshot testing#27754
tgross wants to merge 1 commit intomainfrom
ui-remove-percy

Conversation

@tgross
Copy link
Copy Markdown
Member

@tgross tgross commented Mar 24, 2026

Percy hasn't contributed anything useful in the entire time we've used it and just causes a lot of false-positive failures. Access control to the service has been painful (particularly following the org migration, where it simply doesn't work for some members of the team), and there's no one maintaining the integration. Let's rip it out.

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Percy hasn't contributed anything useful in the entire time we've used it and
just causes a lot of false-positive failures. Access control to the service has
been painful (particularly following the org migration, where it simply doesn't
work for some members of the team), and there's no one maintaining the
integration. Let's rip it out.
PERCY_TOKEN: ${{ env.PERCY_TOKEN || secrets.PERCY_TOKEN }}
PERCY_PARALLEL_NONCE: ${{ needs.pre-test.outputs.nonce }}
run: |
pnpm exam:parallel --split=${{ matrix.split }} --partition=${{ matrix.partition }} --json-report=test-results/test-results.json
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently failing here because

The option '--json-report' is not registered with the 'exam' command. Run ember exam --help for a list of supported options.
EmberExam: You must specify a split value in order to use partition.

I assume because we're not wrapping ember exam with Percy anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant